Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) cast from json should always nullable #34707

Merged
merged 1 commit into from
May 13, 2024
Merged

[fix](Nereids) cast from json should always nullable #34707

merged 1 commit into from
May 13, 2024

Conversation

morrySnow
Copy link
Contributor

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40868 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b870c7b4914dc3f56ec58489539671f469f4820, data reload: false

------ Round 1 ----------------------------------
q1	17612	4322	4199	4199
q2	2023	188	189	188
q3	10493	1215	1194	1194
q4	10204	843	772	772
q5	7483	2734	2687	2687
q6	222	127	132	127
q7	1020	615	560	560
q8	9219	2150	2074	2074
q9	9063	6756	6718	6718
q10	10055	3864	3880	3864
q11	431	240	244	240
q12	475	216	214	214
q13	18143	3122	3222	3122
q14	267	205	213	205
q15	511	464	480	464
q16	530	399	383	383
q17	980	751	654	654
q18	8185	7665	7752	7665
q19	6204	1562	1551	1551
q20	641	324	317	317
q21	5193	3401	4190	3401
q22	360	269	285	269
Total cold run time: 119314 ms
Total hot run time: 40868 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4526	4395	4455	4395
q2	372	253	268	253
q3	3112	2866	2869	2866
q4	1977	1542	1568	1542
q5	5388	5470	5478	5470
q6	215	122	122	122
q7	2311	1936	1954	1936
q8	3271	3393	3429	3393
q9	8574	8661	8672	8661
q10	4038	3729	3794	3729
q11	587	496	487	487
q12	821	608	630	608
q13	15957	3128	3123	3123
q14	300	265	257	257
q15	541	474	473	473
q16	494	415	422	415
q17	1809	1537	1514	1514
q18	7489	7382	7516	7382
q19	1637	1548	1562	1548
q20	1961	1736	1750	1736
q21	4791	4808	4890	4808
q22	587	492	488	488
Total cold run time: 70758 ms
Total hot run time: 55206 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186574 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b870c7b4914dc3f56ec58489539671f469f4820, data reload: false

query1	908	362	341	341
query2	6441	2235	2309	2235
query3	6652	213	218	213
query4	26591	21235	21178	21178
query5	4169	408	405	405
query6	255	166	167	166
query7	4573	296	286	286
query8	245	200	205	200
query9	8426	2407	2390	2390
query10	442	252	248	248
query11	14721	14139	14102	14102
query12	135	89	87	87
query13	1642	374	371	371
query14	9575	8498	7567	7567
query15	248	168	175	168
query16	8016	266	266	266
query17	1727	574	555	555
query18	2092	278	277	277
query19	273	150	151	150
query20	92	85	84	84
query21	197	123	128	123
query22	5055	4921	4892	4892
query23	34079	33431	33453	33431
query24	7467	2857	3008	2857
query25	568	360	357	357
query26	689	156	155	155
query27	2141	322	318	318
query28	5320	2072	2042	2042
query29	832	606	619	606
query30	254	150	151	150
query31	966	749	740	740
query32	91	52	54	52
query33	555	241	237	237
query34	861	485	479	479
query35	763	642	668	642
query36	1078	864	906	864
query37	104	66	70	66
query38	2921	2802	2787	2787
query39	1616	1539	1547	1539
query40	199	125	122	122
query41	41	39	37	37
query42	99	98	94	94
query43	575	547	565	547
query44	1028	728	716	716
query45	263	259	261	259
query46	1080	729	725	725
query47	1969	1869	1912	1869
query48	378	285	290	285
query49	842	384	395	384
query50	766	392	375	375
query51	6812	6761	6833	6761
query52	106	87	85	85
query53	348	273	274	273
query54	537	415	418	415
query55	73	71	73	71
query56	236	224	221	221
query57	1222	1112	1134	1112
query58	215	189	193	189
query59	3344	3098	3309	3098
query60	251	227	233	227
query61	90	102	85	85
query62	607	469	474	469
query63	307	275	271	271
query64	8409	7356	7393	7356
query65	3134	3072	3074	3072
query66	776	360	330	330
query67	15318	15138	14976	14976
query68	4511	538	528	528
query69	536	303	299	299
query70	1164	1142	1095	1095
query71	398	259	267	259
query72	7828	2569	2345	2345
query73	714	323	323	323
query74	6473	6126	6036	6036
query75	3427	2650	2627	2627
query76	2861	1025	1000	1000
query77	574	261	260	260
query78	10724	10156	10156	10156
query79	1886	509	512	509
query80	874	435	426	426
query81	519	262	219	219
query82	784	93	91	91
query83	240	162	162	162
query84	248	87	84	84
query85	1106	269	275	269
query86	416	294	303	294
query87	3356	3098	3162	3098
query88	3422	2395	2395	2395
query89	479	363	374	363
query90	1988	183	186	183
query91	123	99	100	99
query92	55	47	50	47
query93	1823	512	497	497
query94	1255	184	176	176
query95	391	303	302	302
query96	593	272	265	265
query97	3123	2987	2996	2987
query98	248	224	214	214
query99	1169	916	950	916
Total cold run time: 275113 ms
Total hot run time: 186574 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit 97a10d2 into apache:master May 13, 2024
26 of 29 checks passed
@morrySnow morrySnow deleted the cast_from_json_always_nullabe branch May 13, 2024 06:42
nextdreamblue pushed a commit to nextdreamblue/doris that referenced this pull request May 13, 2024
@morrySnow @nextdreamblue
[fix](Nereids) cast from json should always nullable (apache#34707)
339503a
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
@morrySnow @ByteYue
[fix](Nereids) cast from json should always nullable (apache#34707)
fc61742
yiguolei pushed a commit that referenced this pull request May 18, 2024
@morrySnow @Doris-Extras
[fix](Nereids) cast from json should always nullable (#34707)
c71d0b6
@morningman morningman mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @starocean999 @eldenmoon @dataroaring